Ensure all CI steps are run for tags #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stated in the CircleCI docs (https://circleci.com/docs/2.0/configuration-reference/#tags), if a job has a tag filter, all dependent jobs must have the same tag filter. Given that the `publish_images` job depends on all the other jobs, these must also have the same tag filter. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As stated in the CircleCI docs, if a job has a tag filter, all dependent jobs
must have the same tag filter. Given that the
publish_imagesjobdepends on all the other jobs, these must also have the same tag filter.
Signed-off-by: Bridget McErlean bmcerlean@vmware.com